Vitis hls#136
Merged
acastellane merged 26 commits intomasterfrom Jul 30, 2021
Merged
Conversation
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: acastellane <castella@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Alexandre CASTELLANE <alexandre.castellane@fr.ibm.com>
Signed-off-by: acastellane <castella@fr.ibm.com>
Signed-off-by: acastellane <castella@fr.ibm.com>
Signed-off-by: acastellane <castella@fr.ibm.com>
Signed-off-by: acastellane <castella@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
Signed-off-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com>
typos in comments
clean commented lines
bmesnet
previously approved these changes
Jul 26, 2021
| add_files -norecurse $ip_dir/hbm/hbm.srcs/sources_1/bd/hbm_top/hdl/hbm_top_wrapper.vhd >> $log_file | ||
| #add_files -norecurse $ip_dir/hbm/hbm.srcs/sources_1/bd/hbm_top/hdl/hbm_top_wrapper.vhd >> $log_file | ||
| add_files -norecurse $ip_dir/hbm/hbm.gen/sources_1/bd/hbm_top/hdl/hbm_top_wrapper.vhd >> $log_file | ||
| if { $bram_used == TRUE } { |
Collaborator
There was a problem hiding this comment.
2020.1 has changed path /hbm.srcs/ to /hbm.gen/.
Have you checked that HBM example still works with vivado <= 2019.2?
Thx
Signed-off-by: Alexandre CASTELLANE <alexandre.castellane@fr.ibm.com>
fleon-psi
pushed a commit
to fleon-psi/oc-accel
that referenced
this pull request
May 6, 2022
* changes to support vitis HLS * remove unused Flash wrapper * restore 12 HBM * adapt scripts for hbm * update for ubuntu default shell * bsp_wo_pblock_1 * correct lib calls * tune axis for vitis * tune path before calling xsim with vivado 2020.1 and later * Update hls.mk * Update create_framework.tcl * synchro with oc-bip Co-authored-by: Bruno Mesnet <bruno.mesnet@fr.ibm.com> Co-authored-by: acastellane <castella@fr.ibm.com> (cherry picked from commit 970bd72)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xsim simulations tested successfully on 2019.1 and 2019.2. Lets go for it.